[HOLD for payment 2023-06-23] [$1000] Welcome message input field not auto focused

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1.Go to the chat
2.Send a message to user
3.Click on "Reply in thread"
4.Click on thread header > Settings > Welcome message

Expected Result:

Welcome message input field should auto focused when click on "Welcome message"

Actual Result:

Welcome message input field not not auto focused

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230529004642.mp4

az_recorder_20230606_172209.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685303840840829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af6bfe68d473c41b
• Upwork Job ID: 1666483320229822464
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome message input field not auto focused

What is the root cause of that problem?

App/src/pages/ReportWelcomeMessagePage.js

Lines 75 to 86 in 08b1bf6

	<TextInput
	inputID="welcomeMessage"
	label={props.translate('welcomeMessagePage.welcomeMessage')}
	multiline
	numberOfLines={10}
	maxLength={CONST.MAX_COMMENT_LENGTH}
	ref={welcomeMessageInputRef}
	value={welcomeMessage}
	onChangeText={handleWelcomeMessageChange}
	autoCapitalize="none"
	textAlignVertical="top"
	/>

See in the textinput of ReportWelcomeMessagePage Component, we don't set autoFocus and also don't use ref to focus textinput when componentDidmount

What changes do you think we should make in order to solve the problem?

Add autofocus in here

App/src/pages/ReportWelcomeMessagePage.js

Line 75 in 08b1bf6

<TextInput

like this

 <TextInput
                                autoFocus
                                shouldDelayFocus // OPTIONAL

What alternative solutions did you explore? (Optional)

We can do the same thing in the WorkspaceInviteMessagePage by introducing a new ref and assigning it to the textInput.

 <TextInput
                                ref={(el) => (this.welcomeMessageInputRef = el)}

Then in componentDIdMount we call focus() function of this ref like this

componentDidMount() {
        this.focusTimeout = setTimeout(() => {
            this.welcomeMessageInputRef.focus();
        }, CONST.ANIMATED_TRANSITION);
    }

[ahmedGaber93]

Duplicated #20140
my proposal here before this issue is created with 2 days.

Proposal

Please re-state the problem that we are trying to solve in this issue.

New Room - No focus in Welcome message input field.

What is the root cause of that problem?

The current auto focus setting work based on incorrect prop onTransitionEnd here.
there is no prop called onTransitionEnd in ScreenWrapper, the correct prop called onEntryTransitionEnd

App/src/pages/ReportWelcomeMessagePage.js

Lines 51 to 58 in 12d2f3c

	<ScreenWrapper
	onTransitionEnd={() => {
	if (!welcomeMessageInputRef.current) {
	return;
	}
	welcomeMessageInputRef.current.focus();
	}}
	>

What changes do you think we should make in order to solve the problem?

We have two solution.

Solution A.

we can use onEntryTransitionEnd prop instead of onTransitionEnd and change the ref definition to be Callback Ref like this ref={(el) => (welcomeMessageInputRef.current = el) to prevent null ref.

 <ScreenWrapper 
     // onTransitionEnd={() => {
     onEntryTransitionEnd={() => { 
         if (!welcomeMessageInputRef.current) { 
             return; 
         } 
         welcomeMessageInputRef.current.focus(); 
     }} 
 > 
 
 
<TextInput
    // ref={welcomeMessageInputRef}
    ref={(el) => (welcomeMessageInputRef.current = el)}

Solution B.

use prop autoFocus to TextInput here.

What alternative solutions did you explore? (Optional)

Solution B above.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01af6bfe68d473c41b

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)