[HOLD for payment 2023-07-03] [$1000] IOU has pin option in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send money request to user B
2. Open the IOU thread
3. Right-click on IOU thread LHN

4. Click on 'Pin' button
5. Observe that IOU thread is pinned to the top but that there is no pin icon on the LHN

Expected Result:

Pin option shouldn't show since the IOU/expense report can't be pinned because it has the green dot.

Pin icon should be displayed on LHN when pinning the thread, and the pin icon should be removed when unpinning the thread

Actual Result:

Pin option is shown.

Pin icon is not displayed when pinning the IOU thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-06-03.09.03.46.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685772909333819

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139b2338fd7598cc2
• Upwork Job ID: 1668415046377648128
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The LHN context menu allows the user to pin IOU threads.

What is the root cause of that problem?

As per #19438 (comment), IOU reports should not have any pin options as they are pinned by default, but the transaction chats should. Whereas this new contextmenu functionality is enabled for all reports

What changes do you think we should make in order to solve the problem?

We should disable the pin button on the contextmenu for IOU reports.
To implement this, in OptionRowLHN we can create a variable returned by SidebarUtils.getOptionData to check if the report is an IOU, and either pass optionItem.isIOU to ReportActionContextMenu.showContextMenu() or early return in showPopover if optionItem.isIOU is true.
The first approach is probably the better way to do it incase more popover menuitems need to be added in the future. We can then pass this isIOU variable along to ContextMenuActions and return false if it is an IOU report.
One issue here is that the ContextMenu still opens even if there are no menuitems, this can be resolved in BaseReportActionContextMenu by checking if the filtered context menu actions are empty using _.map and calling hideContextMenu if this is the case.

What alternative solutions did you explore? (Optional)

None

[mallenexpensify]

I think this is expected behaviour but .... ¯_(ツ)_/¯.
Checking here

Is it expected behavior to NOT show the 📌 in LHN for an IOU thread? Asking because we're currently showing the :greenlight: and the chat is pinned at the top. ie. the :greenlight: supersedes the 📌 since money is owed (and it's pinned at the top of LHN) so therefore we want to continue to show :greenlight: and not 📌 .... right?

[Ollyws]

There was a discussion about this in #19438 (comment) as far as the pin icon/green light is concerned the current behaviour is expected, the problem here is that there is the option to pin/unpin IOUs from the LHN context menu which shouldn't be there, if you look at the IOU header in the chat it has no pin option.

[Natnael-Guchima]

I think @trjExpensify might know what the expected behaviour should be here.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

the problem here is that there is the option to pin/unpin IOUs from the LHN context menu which shouldn't be there,

@Ollyws , good catch. It does make sense that, if the chat isn't pin-able, then we shouldn't show the option. I like that better than allowing pinning

I was going to put this on hold pending the below but noticed it hit production a week ago and that worked on the PR for that @Ollyws

• PAID] [$1000] IOU threads don't have pin options #19438

I updated the OP, moving this along