[HOLD on prioritizing P2P] IOU - Button doesn't show the expected text "Pay" or "Pay Elsewhere"

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Case 1 - Short Pay button label in the report preview

Action Performed:

1. As userA, request $10 from userB
2. As user B, check the button in the IOU

Expected Result:

The IOU should display only one button with no dropdown option saying simply "Pay". Expected result extracted from this PR.
#19817

Actual Result:

The button displays "Pay Elsewhere" instead of "Pay".

Case 2 - Pay Elsewhere shows instead of I'll settle up elsewhere in case of expense reports

Action Performed:

1. UserA creates a workspace and invites UserB as a member
2. UserB requests money from this workspace
3. As UserA (admin), go to the expense report
4. Verify you can see Pay elsewhere option and you cannot see I'll settle up elsewhere option

Expected Result:

The IOU should display only one button with no dropdown option saying simply "Pay Elsewhere". Expected result extracted from this PR.
#19817

Actual Result:

The button displays "Pay" instead of "Pay Elsewhere" and when navigating to the IOU, the user can see the option to "Pay Elsewhere" in the dropdown.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24-1

Reproducible in staging?: Yes
Reproducible in production?: No, this is a new change to the button

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team
Slack conversation:

View all open jobs on GitHub

Issue found while executing PR #19817 - Assigning @mountiny as he was the author of the PR.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@isagoico Thanks for raising it but these are expected, maybe it was not clear in the test steps, sorry it was a lot of changes and hard to describe.

The single Pay button from the chat should show:

• Pay if the methods are Wallet or VBBA which would be used upon click
• Pay with Paypal if the method is paypal
• Pay elsewhere if the method used would be elsewhere

Then the Expense report detail (workspace request) pay button options should be or:

• Pay with Expensify
• Pay elsewhere

In 1:1 request you wont have the Pay elsewhere, but you will have I'll settle up elsewhere

[mountiny]

I will close this out, I believe there are no testrail steps to update right now, but if yes, please let us know in slack