[HOLD for payment 2023-06-19] [$1000] Reveal message is in english if changed language to spanish

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From Person A: Create a workspace> Invite Person B
2. From Person A: Create a new room in restricted mode
3. From Person A: Send a message on the room
4. From User B: Send a message to the same room
5. From User A: Change language to Spanish and mark the message sent by User B as spam
6. Notice that from User A ,the message was changed to Spanish but the reveal message button is still in english

Expected Result:

Reveal messages should be changed to spanish

Actual Result:

Reveal message is in english if changed language to Spanish

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-01_10.19.14.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685592704388239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a9276f705644149
• Upwork Job ID: 1665661469359173632
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Reveal message" is not localized in chat message item

What is the root cause of that problem?

There's no localization implemented here:

App/src/pages/home/report/ReportActionItem.js

Line 311 in fc30ddc

{isHidden ? 'Reveal message' : 'Hide message'}

What changes do you think we should make in order to solve the problem?

Use same localization here:

App/src/pages/home/report/ReportActionItem.js

Line 281 in fc30ddc

{isHidden ? props.translate('moderation.revealMessage') : props.translate('moderation.hideMessage')}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010a9276f705644149

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[twisterdotcom]

This is one even I could do!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)