[HOLD for payment 2023-08-28] [$2000] Web- Chat - Pressing Copy to clipboard, Copy link, or Mark as unread from the Mini context menu does not refocus the Composer

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Go to any chat
3. Send a message and click anywhere on the page to lose composer focus
4. Hover over the message and click any of these three Copy to clipboard, Copy link, Mark as unread

Expected Result:

Pressing any of these three options Copy to clipboard, Copy link, Mark as unread should have to refocus the composer like we do when using the Context menu

Actual Result:

Pressing any of these three options, Copy to clipboard, Copy link, or Mark as unread is, not refocusing the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

copy-to-clipboard-does-not-focus.1.mov

Recording.2945.mp4

Expensify/Expensify Issue URL:

Issue reported by: @jayeshmangwani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684759049611809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01517d6a9b05f42ab8
• Upwork Job ID: 1666174440708157440
• Last Price Increase: 2023-06-29

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing Copy to clipboard, Copy link, Download, or Mark as unread from the Mini context menu does not refocus the Composer, but Composer is refocused when pressed from the context menu opened from a long press

What is the root cause of that problem?

We are focusing the composer on the above actions if we press from the Context menu and we are doing nothing if we press from the mini menu
here is the condition for checking if the press is from the popover or not and if the press is from the context menu then call the ReportActionComposeFocusManager.focus

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 102 to 104 in c917c44

	if (closePopover) {
	hideContextMenu(true, ReportActionComposeFocusManager.focus);
	}

What changes do you think we should make in order to solve the problem?

We need to add an else condition to Copy to clipboard, Copy link, Download, and Mark as unread(or any other actions) press, where we will call ReportActionComposeFocusManager.focus() if it is not the from Popover, it means mini context menu

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 45 in c917c44

const isMini = !closePopover;

here need to add else and all other presses like Copy to clipboard, Copy link, and Mark as unread

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 102 to 104 in c917c44

	if (closePopover) {
	hideContextMenu(true, ReportActionComposeFocusManager.focus);
	}

  } else {
    ReportActionComposeFocusManager.focus()
  }

What alternative solutions did you explore? (Optional)

none

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01517d6a9b05f42ab8

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)