[HOLD for payment 2023-06-29] [$1000] Workspace name does not change when the room is set to "Public"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to the "New room" option
2. Enter a room name and select a workspace
3. Set the visibility to "Public" and click on "Create room"
4. Proceed to the settings > Workspace section
5. Attempt to edit the workspace name

Expected Result:

When a room within a workspace is set to "Public" modifying the workspace name should reflect the changes

Actual Result:

The workspace name does not change when the visibility is set to "Public" although it works correctly under other conditions

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-05-29-21-11-33_9CI2l3eZ.mp4

Recording.2926.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685377661841849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155889d32c72672f3
• Upwork Job ID: 1664782872269701120
• Last Price Increase: 2023-06-02

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name does not change when the room is set to "Public"

What is the root cause of that problem?

• We're using ReportUtils.getChatRoomSubtitle to get the text to show in the header of a chatReport. In this function, we also call to ReportUtils.getPolicyName to get the policy/WS name. And if it's a public room, it will has report.policyName value to show

App/src/libs/ReportUtils.js

Lines 444 to 448 in 145dd4b

	// Public rooms send back the policy name with the reportSummary,
	// since they can also be accessed by people who aren't in the workspace
	if (report.policyName) {
	return report.policyName;
	}

• Unfortunately, we don't have any mechanism to update report.policyName of public room whenever its Policy/WS updated name => this value report.policyName only be updated when we re-visit the reportRoom, then it will fetch latest data from BE (via OpenReport API command).

What changes do you think we should make in order to solve the problem?

Whenever a Policy/WS updated name, it will:

• optimistic update its name to Onyx
• BE also returns updated name to update back to Onyx
• Pusher also broadcasts updates with updated name of Policy/WS
  

So I think we have enough data to optimistic update report.policyName of public reports in FE side. My idea is we can update the Onyx connect callback here so that, whenever a Policy is changed name in Onyx, we need to find all public Reports of that Policy, then optimistic update report.policyName.

Code reference

Add in this line

        if (allPolicies[key] && allPolicies[key].name !== val.name) {
            const policyID = allPolicies[key].id;
            const policyReports = ReportUtils.getAllPolicyReports(policyID);
            const publicReports = _.filter(policyReports, ReportUtils.isPublicRoom); // or we can filter all the chatReport having policyName
            const updatePolicyNameMergeQueries = {};
            _.each(publicReports, ({reportID}) => {
                updatePolicyNameMergeQueries[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`] = {policyName: val.name};
            });
            Onyx.mergeCollection(ONYXKEYS.COLLECTION.REPORT, updatePolicyNameMergeQueries);
        }

It just demonstrate purpose. The condition to filter publicReports can be updated during Code Review stage.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name does not change when the room is set to "Public"

What is the root cause of that problem?

I agreed with Vinh's root cause of the problem above.

App/src/libs/ReportUtils.js

Lines 444 to 448 in 145dd4b

	// Public rooms send back the policy name with the reportSummary,
	// since they can also be accessed by people who aren't in the workspace
	if (report.policyName) {
	return report.policyName;
	}

With public room, we get the subTitle directly from report.policyName but this value is not updated while we changed Workspace name.

What changes do you think we should make in order to solve the problem?

We should update all the involved reports while changing workspace informations.

const policyReports = _.filter(props.reports, (report) => report && report.policyID === policy.id);
function updateGeneralSettings(policyID, name, currency, policyReports) {


    _.each(policyReports, ({reportID}) => {
        optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
                value: {
                    policyName: name,
                },
        })
    });

}

What alternative solutions did you explore? (Optional)

Another solution that we can fix this from backend.

[puneetlath]

I think it makes sense to update optimistically. Does the back-end send a push right now when the workspace is renamed?

[hoangzinh]

@puneetlath yes i does as I mentioned (also screenshot) in my proposal #19987 (comment)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155889d32c72672f3

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)