[Payment due June 23 2023 $1500] App crashing when sending mention with two underscores

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Start a DM with someone
3. Type a mention (e.g. @Someone) to a chat with two underscores before and after the @ symbols like so:

• Type mention: @concierge@expensify.com
• Manually edit the mention to have underscores like so: @_concierge_@expensify.com

4. Hit send on the manually edited mention

Expected Result:

App shouldn't be crashing

Actual Result:

App crashed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Double.Underscore.on.Mention.2.mp4

Recording.2915.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kerupuksambel

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685210491228269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0192a54b7fe00d88f1
• Upwork Job ID: 1666449278662524928
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashing when sending mention with two underscores

What is the root cause of that problem?

When we call replace function in expensify-common, userMentions rule is apply before italic rule, that makes after translate to html inside metion-user tag has both text and em tag.

So that when render by react-native-render-html, props.tnode now is TPhrasing and props.tnode.data is undefined. And then this line makes app crashes

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 33 in f78f286

const loginWhithoutLeadingAt = props.tnode.data.slice(1);

What changes do you think we should make in order to solve the problem?

In expensify-common lib, we should move userMentions and other rules that don't allow other tags inside to the last of list rule

What alternative solutions did you explore? (Optional)

NA

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When sending mention with two underscores, app crashes

What is the root cause of that problem?

When sending @_sangar_@gmail.com, it is converted to <mention-user>@<em>sangar</em>@gmail.com</mention-user>. In cases mention-user has several elements, tnode props has not data property, instead it has children property.

We didn't consider this case and this is the main reason.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 33 in e77f0a0

const loginWhithoutLeadingAt = props.tnode.data.slice(1);

What changes do you think we should make in order to solve the problem?

We need to take into consideration the cases tnode has several children.

1. Write a function named getUserAddress that takes tnode as its parameter and returns user's address. This function would return @sangar@gmail.com in the above case.

2. Replace the above line in MentionUserRenderer with the following code.

    const userAddress = getUserAddress(props.tnode);
    const loginWhithoutLeadingAt = userAddress.slice(1);

This works great.

Result

mac_chrome_19957.mp4

What alternative solutions did you explore? (Optional)

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashing when sending mention with two underscores.

What is the root cause of that problem?

The root cause of this issue is that user mention input

@_concierge_@expensify.com

is translated into html

<mention-user>@<em>concierge</em>@expensify.com</mention-user>

which causes error when App renders the html, see console error stack

From

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 33 in 37644c5

const loginWhithoutLeadingAt = props.tnode.data.slice(1);

props.tnode.data is undefined.

What changes do you think we should make in order to solve the problem?

To fix this issue, we should avoid rendering italic syntax(which is described by underscore character _) for text inside <mention-user> tag. To achieve this, we can improve the regex of italic rule. We can change it

/(?!_blank")[^\W_]?_((?![\s_])[\s\S]*?[^\s_])_(?![^\W_])(?![^<]*(<\/pre>|<\/code>|<\/a>|_blank))/g,

to

/(?!_blank")[^\W_]?_((?![\s_])[\s\S]*?[^\s_])_(?![^\W_])(?![^<]*(<\/pre>|<\/code>|<\/a>|<\/mention-user>|_blank))/g,

by improving the ending negative lookahead group to skip text matching text inside <mention-user> tag just like what we do for other tags.

By doing so, user mention input

@_concierge_@expensify.com

is translated into

<mention-user>@_concierge_@expensify.com</mention-user>

which fixes the App crash issue and won't break existing unit test cases of expensify-common.

See demo video

Screen.Recording.2023-06-02.at.12.02.00.PM.mov

bold and strikethrough syntax may have similar issue, so we can apply same fix for them as well.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

[michaelhaxhiu]

@kbecciv the steps you provided under Action Performed: don't seem like the actual steps?

Shouldn't your steps include this? @_concierge_@expensify.com ?

[kbecciv]

Hello @michaelhaxhiu! Let me check

[kbecciv]

I added correctly, but when I saved it does not look good for reproduction.

[michaelhaxhiu]

Ahhh I see! Thank you for clarifying. I was testing both just now :)