[$1000] LHN- Thread messages chat for own messages do not appear for other user in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19551

Action Performed:

1. Open NewDot on 2 devices with different accounts (better between 2 new users without overwhelming chat history in LHN),
2. Send direct message from A to B
3. Reply in the same chat from B to A
4. Under A create thread messages for both messages in direct message chat

Expected Result:

2 new thread chat should be displayed in LHN for both users (or for account B none thread chats should be created until user clicks those threads in parental chat)

Actual Result:

Account B has only 1 new thread chat displayed in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20.1

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/ca0779c0f785a82874d71bcdfaa8b13ab1ad04ca979931be66333ccb7e52d653

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016c533f8eb6537f28
• Upwork Job ID: 1665749412874715136
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A sends message to B. The message appears on LHN of B. A replies to this message. This thread appears on LHN for A. But since this is a reply to message sent to B, it should appear on LHN of B as well. But it does not appear in LHN of B.

What is the root cause of that problem?

When A replies to their own message, it triggers navigateToAndOpenChildReport of Report.js but this line below does not include B among the participants for this reply because here participiants include currentUserEmail and parentReportAction.actorEmail only and both of them are same here since A replies to their own message.

App/src/libs/actions/Report.js

Line 473 in 0813e2c

const participants = _.uniq([currentUserEmail, parentReportAction.actorEmail]);

So B would not be included anywhere in this reply.

What changes do you think we should make in order to solve the problem?

We should include participants (that is B and any others) of the A's initial message here in the participants.
So we change that line to

const participants = _.uniq([currentUserEmail, parentReportAction.actorEmail, ...lodashGet(allReports, [parentReportID, 'participants'], [currentUserEmail])]);

Now this includes B among the participants for the reply message as well and these replies would appear on B's LHN.

What other solutions did you explore?

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016c533f8eb6537f28

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)