[HOLD for payment 2023-06-13] Web - Workspace - Crash when delete WS offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Workspaces -> Open any WS
4. Turn off the internet connection
5. Click on 3 dots
6. Click Delete Workspace

Expected Result:

The workspace should be deleted and the app should like like it does when a Workspace is deleted and you're online (assuming that's possible)

Actual Result:

App crashed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

**Version Number:**1.3.20-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/cc69e6dc7c5b9148cfbdbbfaa6e5ad84f396c9fd74cce7056bc49422ca889fc3

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @situchan

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b04e507bd3a3505c
• Upwork Job ID: 1670914877687336960
• Last Price Increase: 2023-06-19

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when workspace is deleted while offline

What is the root cause of that problem?

The root cause of the issue is that when the user is offline and workspace gets deleted, this prop changes to: {pendingAction: 'delete'}. When this happens, this function gets executed which returns an array of elements. The input to the function was a single element. The array of elements when supplied to the Tooltip function as a children prop results in this condition to return false, causing an exception.

What changes do you think we should make in order to solve the problem?

We can edit the applyStrikeThrough function such that a single element is not converted to an array ie

const mutatedChildrens = React.Children.map(children, (child) => {
        if (!React.isValidElement(child)) {
            return child;
        }
        const props = {style: StyleUtils.combineStyles(child.props.style, styles.offlineFeedback.deleted, styles.userSelectNone)};
        if (child.props.children) {
            props.children = applyStrikeThrough(child.props.children);
        }
        return React.cloneElement(child, props);
    });
    return React.Children.count(mutatedChildrens) > 1 ? mutatedChildrens : mutatedChildrens[0];

What alternative solutions did you explore? (Optional)

We can also edit the condition here to be:

if (!React.isValidElement(React.Children.toArray(this.props.children)[0])) {

This will need to be changed to:

     {React.Children.only(React.Children.toArray(this.props.children)[0])}

The above approach assumes that Tooltip component allow for a single child only.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Was able to reproduce, I updated the Expected Behaviour to mimic what happens when your online and you delete a Workspace. @tylerkaraszewski and @allroundexperts, do you agree that should be the expected behaviour?

@tylerkaraszewski , do you think this can be External?

2023-05-30_17-38-41.mp4

[situchan]

I reported this early in slack. As it's within regression period, maybe assigned folks in #15796 will handle this?

[allroundexperts]

@situchan I don't think this is a regression. The issue seems to be in our applyStrikeThrough function which accepts a single element as an input and converts it into an array. Ideally, the input and output format should remain the same for this function.