[HOLD for payment 2023-06-21] [$1000] Avatar has no tooltip in thread report header

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new room from any workspace (if not exist)
2. Send any message in room chat
3. Thread that message
4. Hover avatar on thread report header or on LHN

Expected Result:

Tooltip shows with thread creator's avatar title

Actual Result:

No tooltip and Tooltip shows "fake" text in workspace chat thread header

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

241282990-6e9b9545-d5de-4093-9ef3-43d109d07f4c.mov

Recording.816.mp4

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685268118865469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f86178576b081ad
• Upwork Job ID: 1665777714293276672
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar has no tooltip in thread report header

What is the root cause of that problem?

There are 3 bugs:

• Bug 1: Currently, we don't show tooltip when hover on top-left avatar when we're in a chatRoom.
  

  App/src/pages/home/HeaderView.js

  Line 162 in 16776ec

  shouldShowTooltip={!isChatRoom}

  
  Unluckily, if we open a thread from a chatRoom, the threadReport also a chatRoom.

• Bug 2: Tooltip shows "fake" text in WS Thread LHN
  When we create a thread from a WS chat, its chatRoom type will also a PolicyExpenseChat => leads to condition to show report subscript is true here => it will shows SubscriptAvatar instead of MultipleAvatars like other Threads. In SubscriptAvatar it will show report.ownerEmail in tooltip but for Thread it's always __fake__

• Bug 3: Tooltip shows "fake" text in WS Thread report header
  Same root cause with 2nd bug above, in Report header view, we will render subscript avatar if it's a PolicyExpenseChat

What changes do you think we should make in order to solve the problem?

• Bug 1:
  We need to update condition here so that it still show tooltip if it's isChatRoom and isThread too.

shouldShowTooltip={!(isChatRoom  && !isThread)}

We need update this line with above logic too. So it will show tooltip when hover on avatar in LHN

Result:

• Bug 2:
  We should update condition here to also check it's not a Thread report

• Bug 3:
  We should update condition here to include it's not a Thread report

Result:

[0xmiroslav]

This is a follow-up of #19551 and I am happy to take this as C+ since I already have full context while reviewing that PR.
cc: @sakluger

[sakluger]

I can't get fake to show up on hover, but it does just show nothing. We also show nothing though when hovering over the avatar for an #admins room. Asking in Slack to confirm that this is the intended behavior: https://expensify.slack.com/archives/C04QEB4MJEQ/p1685639994048869?thread_ts=1684920485.401849&cid=C04QEB4MJEQ

[sakluger]

Reassigning BZ label since I'm OOO next week.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.