[HOLD for payment 2023-06-19] [$1000] The name/picture is not dynamically updated if the emoji popup is open but works well with emoji numbers

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1.Go to staging dot on chrome -> User 1
2. From User 1, go to any chat with User 2 and message them
3. React to the same message
4. From User 2 account, react to the same emoji and right click on emoji to openup the popup
5. From User 1 account. unreact to the emoji and see that on User 2 side, the user who reacted to the emoji and the emoji number dynamically updates
6. From User 1, now try to change the display name or the profile picture and see that on the User 2, the display name doesn't update dynamically on popup (you need to click somewhere else and again right click on the emoji to see the updated display name in the popup)

Expected Result:

The profile picture or the display name of the User 1 should be dynamically updated on the emoji reactions list on the popup

Actual Result:

The name/picture is not dynamically updated if the emoji popup is open but works well with emoji numbers

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-26_16.13.00.mp4

Recording.803.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685097484082299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011746eb5669d607e7
• Upwork Job ID: 1663928154895839232
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The name/picture is not dynamically updated if the emoji popup is open but works well with emoji numbers

What is the root cause of that problem?

PopoverReactionList use HOC withCurrentUserPersonalDetails that contains personalDetails props, but in shouldComponentUpdate we don't check the change of personalDetail so that when personalDetails is changed, shouldComponentUpdate returns false and then name/picture of personal is not updated.

App/src/pages/home/report/ReactionList/PopoverReactionList.js

Line 70 in e4c5c54

shouldComponentUpdate(nextProps, nextState) {

What changes do you think we should make in order to solve the problem?

We should check the change of personalDetails props in shouldComponentUpdate function by adding this.props.personalDetails !== nextProps.personalDetails || when return in shouldComponentUpdate function.

App/src/pages/home/report/ReactionList/PopoverReactionList.js

Line 76 in e4c5c54

return (

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.30-05-2023.09.50.14.webm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011746eb5669d607e7

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @dangrous (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.