[HOLD for payment 2023-06-29] [$1000] Console error when selecting a user to assign a task to

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Go to "Assign Task" section
3. Enter the task title and click on the "Next" button
4. Then click on "Confirm task"
5. Click on "To" and select a user

Expected Result:

A console error should not appear

Actual Result:

Console error when selecting a user to assign a task to

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-25.00-49-45.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684958586982989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ca7b76593b61b50d
• Upwork Job ID: 1663406805379948544
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error shows after selecting assignee on task assignee selector page

What is the root cause of that problem?

This came from lack knowledge of lifecycle in functional component.
In TaskAssigneeSelectorModal, there's search_render measurement.
Timer should start on component mount and should end only on OptionsSelector onLayout callback or component unmount.
In current logic, there are more cases of start/end timer: whenever props or search value are changed because of [updateOptions] dependency.

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 110 to 114 in d70b746

	return () => {
	Timing.end(CONST.TIMING.SEARCH_RENDER);
	Performance.markEnd(CONST.TIMING.SEARCH_RENDER);
	};
	}, [updateOptions]);

So finally these are call orders in Timing.js:

• end
• start
• end
• start
• getEnvironment promise return
• getEnvironment promise return (error happens here because key is removed by this line)
• start
• end
• getEnvironment promise return

What changes do you think we should make in order to solve the problem?

As this measurement is unintentionally (confirmed here) added in this page, we can safely remove this effect and onLayout callback.

Also remove same in TaskShareDestinationSelectorModal.

What alternative solutions did you explore? (Optional)

Early return if key doesn't exist here

[bfitzexpensify]

Reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ca7b76593b61b50d

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)