[HOLD for payment 2023-06-08][$1000] Dev: Console error on reload page in Connect bank account page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces > Connect bank account
2. Click on connect manually
3. Reload the page

Expected Result:

It should not show any console error

Actual Result:

Shows console error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-1

Reproducible in staging?: No

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-25.at.3.19.24.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1685008322770599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0164470c9b3ebb6fd2
• Upwork Job ID: 1664363385558638592
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Dev: Console error on reload page in Connect bank account page

What is the root cause of that problem?

• The root cause is we recently migrated CheckboxWithLabel component to use PressableWithFeedback on PressableWithFeedback we have not provided accessibilityLabel that’s causes the error as this should be mandatory as focusable is always true that required accessibilityLabel this error can be visible wherever we used CheckboxWithLabel

What changes do you think we should make in order to solve the problem?

• We need to add accessibilityLabel in order to remove the error log this is mandatory because by default focusable is true so we do need to provide accessibilityLabel

• We can also add the optional accessibilityRole

• We need to define a new accessibilityHints for CheckboxWithLabel which will be passed to accessibilityLabel message in both language 


• If we don’t need accessibilityLabel inside CheckboxWithLabel then we can just pass accessible to false this will also remove the error

     <PressableWithFeedback
+       accessibilityRole="button" // can be decide later 
+       accessibilityLabel={'Custom message here'}

Result

Without fix

[sonialiap]

Has been reproduced, adding External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0164470c9b3ebb6fd2