[HOLD for payment 2023-06-09] [$1000] email is not shown in copy button but URL is shown in copy button

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat and send 2 messages, a url and an email
2. Press and hold to open the copy menu
3. Observe them

Expected results:

both should display what we are copying or both should not

Actual results:

URL is shown but email is not shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-05-24.10-54-52-681.mp4

Recording.789.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684650130184679

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113fb75b15c02216f
• Upwork Job ID: 1663403883726782464
• Last Price Increase: 2023-05-30

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• email is not shown in copy button but URL is shown in copy button

What is the root cause of that problem?

• Root cause is we are not passing email to getDescription() inside ContextMenuActions.js that makes email not to show on long press whereby on url we do pass getDescription () which works as expected to show all the url while copying

What changes do you think we should make in order to solve the problem?

• To show email on long press on ContextMenu we need to pass selected email to getDescription() which will be selection props also we do need to remove mailto: from email for that we can add similar replace function as we did while copying actual mail 


• If we are required to remove web/email from the copy context menu then we should remove getDescription from both the option

// ContextMenuActions.js

textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',
+getDescription: (selection) => selection.replace('mailto:', ‘’),

[bfitzexpensify]

Reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113fb75b15c02216f

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[melvin-bot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.