[HOLD #19611] [$1000] IOU - Uh-oh, something went wrong! message on sign out after going through IOU chats

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Open any chat with money request (or create money request)
3. Click IOU thread in main chat
4. Click IOU preview
5. Sign out

Expected Result:

Login page with no errors

Actual Result:

Error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/0634fb3baeb4596d3af33049107cf1020457e73d4c5ecd56dfa137de28800be5

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113873001d05bf238
• Upwork Job ID: 1662181026806792192
• Last Price Increase: 2023-05-26

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Signing out on the IOU screen causes the app to crash.

What is the root cause of that problem?

The root cause is that the user to whom the IOU is sent isn't added to the participants list.

App/src/pages/home/report/ReportActionCompose.js

Lines 905 to 909 in 0070968

	render() {
	const reportParticipants = _.without(lodashGet(this.props.report, 'participants', []), this.props.currentUserPersonalDetails.login);
	const participantsWithoutExpensifyEmails = _.difference(reportParticipants, CONST.EXPENSIFY_EMAILS);
	const reportRecipient = this.props.personalDetails[participantsWithoutExpensifyEmails[0]];

Therefore, The ParticipantLocalTime component does not get its required prop and throws and error.

App/src/pages/home/report/ReportActionCompose.js

Line 932 in 0070968

{shouldShowReportRecipientLocalTime && <ParticipantLocalTime participant={reportRecipient} />}

What changes do you think we should make in order to solve the problem?

Assuming by design to not include the user to whom the IOU has been requested, then we can just proceed with the following:

{(shouldShowReportRecipientLocalTime && reportRecipient) && <ParticipantLocalTime participant={reportRecipient} />}

This will prevent the error because the ParticipantLocalTime will only render if reportRecipient is there.

[joekaufmanexpensify]

@kbecciv in the future, please make sure your bug reporting steps are clear, and include a video in the report. Otherwise, it can be difficult to know exactly what behavior we're looking for when triaging.

[joekaufmanexpensify]

Reproduced on web:

2023-05-26_15-32-22.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113873001d05bf238

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)