[HOLD for payment 2023-06-19] [$1000] Add boundary to transparent background images on Share QR code screen

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome

2. Click on profile

3. Change the profile picture to any image with background

4. Click the back arrow

5. Click on Share code and notice that the image is shown in circular frame between the QR code that looks great

6. But now try to change the profile picture that has transparent background (example:
   )

7. Click on Share code and notice that since the image doesn't have any background, it looks weird in between the QR code. Thus, a circular frame should be provided in all the images irrespective of the background

Expected Result:

A circular frame should be provided in all the images irrespective of the background in the QR code

Actual Result:

Transparent background images looks weird in Share QR code unlike images with backgrounds

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-23_10.48.01.mp4

Recording.751.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684818587259709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01916a33b50e2bee79
• Upwork Job ID: 1661800609949470720
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transparent background images look weird inside the QR code container

What is the root cause of that problem?

The root cause of this issue is that we're setting a transparent background for the logo explicitly here.

What changes do you think we should make in order to solve the problem?

We can set the background colour to whatever we want here. I think having this same as props.backgroundColor would look good. Otherwise, we can also use rgb(139, 156, 143) as we're using at other places.

If needed, we can also conditionally set the background colour if the image is transparent (by checking the logo extension).

What alternative solutions did you explore? (Optional)

None

[Christinadobrzyn]

• This seems more like a feature request and less a bug but I can reproduce this.
• It might need to be part of our [Polish] Image-related feature request and improvements project
• Going to add an External and Design label to get some input

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01916a33b50e2bee79

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.