[hold for payment 2023-08-30] [$2000] Security - Copy button is displayed without any secret key when the 2FA step 2 page is accessed directly through URL

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Got to https://staging.new.expensify.com/settings/security/two-factor-auth/verify on an account where you have not previously copied or downloaded 2FA secret keys.
2. Sign in if not already.
3. Notice you are not shown the 2FA secret key when the page loads. Nor if you go back, can you see the recovery codes on the previous page.

Expected Result:

Here are how we want to handle all of the various cases related to this issue:

2FA is not enabled, and the user loads:

• new.expensify.com/settings/security/two-factor-auth/codes > we show codes.
• new.expensify.com/settings/security/two-factor-auth/verify > we redirect to step 1 (codes).
• new.expensify.com/settings/security/two-factor-auth/success > we redirect to step 1 (codes).
• new.expensify.com/settings/security/two-factor-auth/enabled > we redirect to step 1 (codes).
• http://new.expensify.com/settings/security/two-factor-auth/disable > we redirect to step 1 (codes).

2FA is enabled, and the user loads:

• new.expensify.com/settings/security/two-factor-auth/codes > we redirect to new.expensify.com/settings/security/two-factor-auth/enabled
• new.expensify.com/settings/security/two-factor-auth/verify > we redirect to [new.expensify.com/settings/security/two-factor-auth/enabled (http://new.expensify.com/settings/security/two-factor-auth/enabled)
• new.expensify.com/settings/security/two-factor-auth/success > we redirect to new.expensify.com/settings/security/two-factor-auth/enabled.
• new.expensify.com/settings/security/two-factor-auth/enabled > they land on enabled.
• http://new.expensify.com/settings/security/two-factor-auth/disable > they land on http://new.expensify.com/settings/security/two-factor-auth/enabled .

Actual Result:

Copy button is there without any secret key shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-24.at.2.28.55.AM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @adeel0202

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684420754597459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f90e1d072b364da
• Upwork Job ID: 1661463527223799808
• Last Price Increase: 2023-06-14

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to regenerate recovery codes when the user visits the security codes page from verify codes page after refreshing the screen no the verify codes page.

What is the root cause of that problem?

Currently the recovery codes are only regenerating in the security settings screen when the 'two factor authentication' option is clicked.

App/src/pages/settings/Security/SecuritySettingsPage.js

Line 43 in a25396f

Session.toggleTwoFactorAuth(true);

What changes do you think we should make in order to solve the problem?

We should move the Session.toggleTwoFactorAuth(true); in SecuritySettingsPage.js#L43 before this line in CodesPage.js

Additionally, we can check if the recovery code is already there and fetch new one accordingly

if (!(props.account.recoveryCodes && props.account.twoFactorAuthSecretKey)) {
    Session.toggleTwoFactorAuth(true);
}

What alternative solutions did you explore? (Optional)

N/A

[joekaufmanexpensify]

I can reproduce this on web. If I had to suspect why this happening, it's because typically when enabling 2FA, we require you to download or copy the recovery codes, before proceeding the step that has the secret key. Whereas by loading https://staging.new.expensify.com/settings/security/two-factor-auth/verify , the user is bypassing this required first step.

IMO, the best solution would be to redirect the user to the first page of the 2FA flow (to copy/download their recovery codes), if they try and load https://staging.new.expensify.com/settings/security/two-factor-auth/verify directly, and have niot previously copied or downloaded their recovery codes.

2023-05-24_15-58-57.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f90e1d072b364da

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)