[HOLD for payment 2023-06-08] [$1000] New tagline after marking as unread have overlapping line

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any message
4. Click on reply to thread on message
5. Send any message on thread
6. Now, mark as unread the thread message

Expected Result:

Should show normal new tagline without overlapping border like line maybe from container of message above

Actual Result:

Overlapped by border like line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

appVid.mov

Expensify/Expensify Issue URL:

Issue reported by: @abhilup

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684409736359709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01505a287c67df838e
• Upwork Job ID: 1661044912992686080
• Last Price Increase: 2023-05-23

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New tagline after marking as unread have overlapping line

What is the root cause of that problem?

Inside ReportActionItemParentAction we're always show this divider line:

App/src/pages/home/report/ReportActionItemParentAction.js

Line 70 in b424edc

<View style={[styles.threadDividerLine]} />

So when the message next to the first message of the thread is marked as read, we will see both this line and mark as read line.

What changes do you think we should make in order to solve the problem?

We should only show this line when the message next to the first message of the thread is already read.
So we should add new props to ReportActionItemParentAction in order to show threadDividerLine only when the message next to the first message of the thread is already read.
So we should update in here:

App/src/pages/home/report/ReportActionsList.js

Lines 113 to 121 in b424edc

	const renderItem = useCallback(
	({item: reportAction, index}) => {
	// When the new indicator should not be displayed we explicitly set it to null
	const shouldDisplayNewMarker = reportAction.reportActionID === newMarkerReportActionID;
	const shouldDisplayParentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED && ReportUtils.isThread(report);
	return shouldDisplayParentAction ? (
	<ReportActionItemParentAction
	reportID={report.reportID}
	parentReportID={`${report.parentReportID}`}

// check if the second message of the thread is unread, then hide the divider line.
const shouldHideThreadDividerLine = sortedReportActions.length > 1 && 
sortedReportActions[sortedReportActions.length -2].reportActionID === newMarkerReportActionID;

                <ReportActionItemParentAction
                    shouldHideThreadDividerLine={shouldHideThreadDividerLine}
                    shouldDisplayNewMarker={shouldDisplayNewMarker}
                    reportID={report.reportID}
                    parentReportID={`${report.parentReportID}`}
                />

and inside ReportActionItemParentAction we also need to update the condition of threadDividerLine.

{!props.shouldHideThreadDividerLine && <View style={[styles.threadDividerLine]} />}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01505a287c67df838e

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.