[$1000] [HOLD for payment 2023-06-13] Crash on split confirm

[amyevans]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This is a follow up issue from #17349 (comment)

Action Performed:

1. (Precondition) Have the desktop app open but not logged in; optionally, throttle your network (see last step)
2. Log in to web
3. In a 1:1 DM, select Send money
4. Copy the URL from the address bar
5. Modify the URL so that it's a deep link (replace http with new-expensify) and open it
6. Follow the deep link prompt to open it in desktop
7. Enter an amount to split and click Next button very quickly (if you are not throttling your network)

Expected Result:

Split confirm page should open

Actual Result:

The app crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

split.confirm.crash.mov

19234-repro-780.mov

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f9b81ec5ac80063
• Upwork Job ID: 1668641221032722432
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hiding this as it's not necessary given the nature of how this issue was created

[amyevans]

@jczekalski please comment on the issue so I can assign you

[jczekalski]

@amyevans

[jczekalski]

@amyevans I pulled the changes from the latest version of main and started looking into this. If I quickly open the Send Money page using slow 3G network throttling or deep link into the page (http://localhost:8080/send/new) I get these errors:

tNumberFormatUnitOptions.js:18 Uncaught TypeError: currency cannot be undefined
The above error occurred in the <TextInputWithCurrencySymbol> component:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'style')
   at eval (index.js:11:1)

Screen.Recording.2023-05-19.at.14.10.58.mov

So I can't get to the confirmation screen without the app crashing. In the video you uploaded, the Send Money page works fine and the errors in the console are different (the app crashes once the confirmation page is opened). It looks like these are new issues, do you know if they've been reported?

[amyevans]

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

[jczekalski]

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

Good point! Sorry, I'm still getting used to this setup :) I posted the bug in the #expensify-bugs channel.

Update: Issue created based on the bug report: #19435