[HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] Fix the settled IOUPreview showing incorrectly

[mountiny]

Make sure that the paid message is not shows as IOUPreview but just as a normal message settled up xxx

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we want to make sure that if the expense has been settled, we show the textual message instead of IOUPreview.

What is the root cause of that problem?

We always show the IOUPreview even if the IOU been paid.

App/src/pages/home/report/ReportActionItem.js

Line 196 in 3b49ca5

(originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && originalMessage.IOUDetails))

What changes do you think we should make in order to solve the problem?

We need to add a condition in the line above, && !originalMessage.paymentType to ensure that if the request has been paid via any method, the IOUPreview is not shown.

Moreover, to show the Settled text on IOUs that have been resolved, we need to update this condition such that (!props.iouReport.hasOutstandingIOU && !props.isBillSplit) ? 'Settled' : ''.

App/src/components/ReportActionItem/IOUPreview.js

Lines 161 to 162 in 5fab2de

	default:
	return '';

The logic flow goes like:

1. If the IOU message has a payment type, then the payment type is shown. I don't think this is possible anymore since we render this message textually with the above changes.
2. Since the normal IOU message doesn't have a payment type, we use the same logic as when to show the green checkmark which denote if the IOU has been settled.
   

   App/src/components/ReportActionItem/IOUPreview.js

   Line 208 in 5fab2de

   {!props.iouReport.hasOutstandingIOU && !props.isBillSplit && (

I can create the PR today itself if the issue is assigned to me for help!

Result:

What alternative solutions did you explore? (Optional)

None

[trjExpensify]

The request preview components should update to Cash - settled [elsewhere] though too.

[trjExpensify]

@mountiny, let's make sure the title of the expenseReport is correct in the LHN (and search) as well. It still shows "workspaceName owes X" instead of "workspaceName settled $50.00 elsewhere":