Unable to request money after settling existing ious

[Julesssss]

cc @mountiny @luacmartins

Problem

Some IOURequests are failing. This is a new regression.

You need to settle a few requests before the bug occurs. It might also be related to workspaces. In my case it is happenening to the workspace admin.

• As userA, Request money
• As userB, pay it
• As userB, Request money
• As userA, pay it
• As userA, request money
• At some point we start. reusing the iouReportID which is a major regression. Theory is listed below

This appears to be occurring because we no longer clear the chatReport.iouReportID property when an IOU is paid. Because of this, this line is reusing an iouReportID instead of generating a new one optimistically.

Solution

Figure out why we aren't clearing the iouReport.iouReportID, or update the mentioned logic so that we don't pass OLD iouReportIDs to the requestMoney API.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b510aa28fd9747e
• Upwork Job ID: 1656328070402617344
• Last Price Increase: 2023-05-10

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b510aa28fd9747e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[Julesssss]

This might be related to missing optimistic data being persisted to Onyx.

[trjExpensify]

Asked @roryabraham in the slack thread if he can take a look at it, as he worked on this optimistic stuff recently.