[HOLD for payment 2023-06-01] [$1000] Show up to 4 participant avatars in the IOUPreview for a bill split

[Julesssss]

Problem

We introduced the IOUPreview for bill splits https://github.com/Expensify/Expensify/issues/270707. But we are only showing one avatar in the IOUPreview when a bill split is created. Instead, we should show up to 4, or 3 if more than 4 participants are included in the split.

Current

Desired

In addition, we should make sure the same order is used when the split is created while offline. (So when returning online, the order shouldn't change)

Solution

Yes please.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a91334bf09c52786
• Upwork Job ID: 1658476194782515200
• Last Price Increase: 2023-05-16

[s77rt]

May be related #15644

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show up to 4 participant avatars in IOUPreview for split bill

What is the root cause of that problem?

The root cause is that we're not using the prop shouldStackHorizontally here.

What changes do you think we should make in order to solve the problem?

We need to add shouldStackHorizontally and set size prop to small. Additionally, the secondAvatarStyle prop needs to be removed. These changes need to be done here only if the isBillSplit is true.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a91334bf09c52786