[HOLD for payment 2023-05-25] [$1000] Payment delete modal menu missing margin at the top

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Go to Settings > Payments
3. If no payment has been added then add any one
4. Press on the added payment method
5. It will open the delete modal from the
6. Press on delete
7. It will open a confirmation modal
8. Observe both modal’s top padding

Expected Result:

There should be some padding between the payment option and the delete modal

Actual Result:

There is no padding between the payment option and the delete modal

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

delete-modal-no-spacing.mov

Recording.525.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682631614889629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01510361e941b5686d
• Upwork Job ID: 1656321116447989760
• Last Price Increase: 2023-05-10

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete Payment modal has a missing margin at the top compared to the payment option.

What is the root cause of that problem?

At the time of calculating the top anchor position in setPositionAddPaymentMenu, we are not adding any additional top margin outside the touch area, so when the user press MenuItem(Payment method), we count the top position like this, MenuItem height + Pressed MenuItem component position from top (position.top + position.height)

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 153 to 162 in 4a4b22b

	setPositionAddPaymentMenu(position) {
	this.setState({
	anchorPositionTop: position.top + position.height,
	anchorPositionBottom: this.props.windowHeight - position.top,
	// We want the position to be 13px to the right of the left border
	anchorPositionRight: (this.props.windowWidth - position.right) + 13,
	});
	}

What changes do you think we should make in order to solve the problem?

We can add the top margin many ways, but I would suggest that when calculating the anchorPositionTop, we should add the six margins to the top of position.top + position.height ,

we should add six here in anchorPositionTop: position.top + position.height + 6

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 155 to 160 in 4a4b22b

	anchorPositionTop: position.top + position.height,
	anchorPositionBottom: this.props.windowHeight - position.top,
	// We want the position to be 13px to the right of the left border
	anchorPositionRight: (this.props.windowWidth - position.right) + 13,
	});

we can add the top margin to individual PopOver too, like this top: this.state.anchorPositionTop + 6 , but for adding the top margin to all the PopOver on page,

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 436 to 439 in 4a4b22b

	anchorPosition={{
	top: this.state.anchorPositionTop,
	right: this.state.anchorPositionRight,
	}}

Why 6 margin ?
We have the 6 margins on this page between Add Payment button and Add Payment popover for consistency we can add 6 (or we can add a margin by confirming with the design team).

Throughout the app, we added different margins from the top and bottom of the touchable area, but for this page, we can use 6.

I am attaching a video here with 6 pixel space

Result

6px-delete.mov

What alternative solutions did you explore? (Optional)

N/A

[bernhardoj]

We do nothing before here https://expensify.slack.com/archives/C049HHMV9SM/p1670338674482959

[slafortune]

I wasn't able to pick out the green border around the delete button - Sheena helped me see it 🙌

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01510361e941b5686d

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)