[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to web chrome
2. Create a new workspace
3. Go to invite members
4. Select any user and go to the message page
5. In the message , copy and paste a large sentence or to make work easier ,copy the existing message present and paste it multiple times until a vertical scrollbar is displayed on the right hand side of the screen
6. Now scroll the page down and notice that even though nothing is present, the page is scrollable down the invite button and has a huge gap

Expected Result:

The invite members message page should not be scrolled down if copy pasted a long message in the message field

Actual Result The invite members message page scrolls down and has a huge gap if copy pasted a long message in the message field

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

date-2023-05-07_09.40.15.mp4

Recording.523.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683432123152429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01569b49604c9ee6e1
• Upwork Job ID: 1655605551638052864
• Last Price Increase: 2023-05-08

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field

What is the root cause of that problem?

We are using the autoGrowHeightprops for TextInput in here:

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 191 in d120f6a

autoGrowHeight

The autoGrowHeight props will add the hidden text input which doesn't have the limit height which caused the problem.

App/src/components/TextInput/BaseTextInput.js

Lines 376 to 384 in d120f6a

	{(this.props.autoGrow || this.props.autoGrowHeight) && (
	// Add +2 to width so that the first digit of amount do not cut off on mWeb - https://github.com/Expensify/App/issues/8158.
	<Text
	style={[...this.props.inputStyle, this.props.autoGrowHeight ? {maxWidth: this.state.width} : {}, styles.hiddenElementOutsideOfWindow, styles.visibilityHidden]}
	onLayout={e => this.setState({textInputWidth: e.nativeEvent.layout.width + 2, textInputHeight: e.nativeEvent.layout.height})}
	>
	{this.state.value || this.props.placeholder}
	</Text>

What changes do you think we should make in order to solve the problem?

We can avoid using autoGrowHeight by using multiline TextInput. So our TextInput will look like:

   <TextInput
                                inputID="welcomeMessage"
                                label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
                                autoCompleteType="off"
                                autoCorrect={false}
                                multiline
                                numberOfLines={numberOfLines}     
                                textAlignVertical="top"
                                containerStyles={[styles.workspaceInviteWelcome]}
                                defaultValue={this.state.welcomeNote}
                                value={this.state.welcomeNote}
                                onChangeText={text => this.setState({welcomeNote: text})}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01569b49604c9ee6e1

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @AndrewGable (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.