[$1000] [HOLD for payment 2023-05-23] [Manual Requests] Display IOU and expense reports in the LHN

[mountiny]

Implement this internal section of the Manual Requests Design Doc. More details to follow.

1. Update getOrderedReportIDs passing iouReports to the list of reports.

const reportsToDisplay = _.filter({...chatReports, …iouReports}, …);

2. Update shouldReportBeInOptionList to stop filtering iou reports and stop checking for the participants as those are missing in expense and iou reports. We will use the isMoneyRequestReport helper method.

if (!report || !report.reportID || !report.participants || (_.isEmpty(report.participants) && !isPublicRoom(report) && !isArchivedRoom(report) && !isMoneyRequestReport(report)) || isIOUReport(report))

3. Update getOptionData to include data for iouReports (subscript avatar, etc)

• Add iouReports here (these are both iou and expense)

const report = chatReports[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]
    || iouReports[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];

• Add result.isMoneyRequestReport here and here
• Update shouldShowSubscript to true for iou reports
• Update getReportName to display the correct workspaceName owes $X message as the reportName
• Update getIcons to return the avatars for the user and Workspace

if (isPolicyExpenseChat(report) || isMoneyRequestReport(report)) {

4 In ReportScreen, we’ll check if the report being rendered is an IOU report and conditionally render MoneyRequestHeader or HeaderView if not.
5. We’ll then render the list of money requests and comments on the Expense / IOU report right under the new header component, using the existing ReportActionsView component.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bc7eb53184f8e07
• Upwork Job ID: 1661760310912589824
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @arielgreen (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mollfpr]

4 In ReportScreen, we’ll check if the report being rendered is an IOU report and conditionally render MoneyRequestHeader or HeaderView if not.

We can skip this step since already done with #18474

[mollfpr]

Update getReportName to display the correct workspaceName owes $X message as the reportName

@mountiny I'm confused about this; how does a user or workspace owe or to whom they owe?

[mollfpr]

Update getIcons to return the avatars for the user and Workspace

We don't need the change here. We will return the user avatar for the IOU report.

App/src/libs/ReportUtils.js

Lines 767 to 773 in 983da48

	if (isIOUReport(report)) {
	return [{
	source: getAvatar(lodashGet(personalDetails, [report.ownerEmail, 'avatar']), report.ownerEmail),
	name: report.ownerEmail,
	type: CONST.ICON_TYPE_AVATAR,
	}];
	}

But in the MoneyRequestHeader, we use the managerEmail to get the avatar instead of ownerEmail. So I'm not sure which one should be followed.