[HOLD for payment 2023-06-01] [$1000] 2FA input should have individual entry like sign in screen

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Enter 2FA enabled email in login field
2. Observe the 2FA input field

Expected Result:

Should have 6 individual field to enter

Actual Result:

Still showing old format

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683226226189909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfe61519061e6012
• Upwork Job ID: 1655982074781265920
• Last Price Increase: 2023-05-09

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that the 2FA code input uses the normal text input instead of the new method to obtain input.

What is the root cause of that problem?

We use the TextInput for verifying 2FA instead of the MagicCodeInput, leading to this issue.

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 203 to 205 in aa6bd41

	{this.props.account.requiresTwoFactorAuth ? (
	<View style={[styles.mv3]}>
	<TextInput

What changes do you think we should make in order to solve the problem?

We need to use MagicCodeInput for 2FA as well and add the props as required. In addition, we will have to add a new prop to pass the maxLength to the MagicCodeInput since it has different CONST variable length for 2FA code and Magic code.

Result

2023-05-05.12-11-06.mp4

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

I would argue this is a new feature.

[melvin-bot]

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.