[HOLD for payment 2023-06-01] [Hold] Inconsistent magic code input format/type between ‘Sign in’ page and ‘Contact methods’ page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign in page
2. Enter email & click on ‘Continue’ button
3. Observe the magic code input format/type
4. Enter magic code and click on ‘Sign in’ button
5. Click on ‘Profile’ avatar
6. Click on ‘Profile’ link
7. Click on ‘Contact methods’ link
8. Click on ‘New contact method’ button
9. Enter email and click on ‘Add’ button
10. Open the newly added email
11. Observe that the magic code input format/type is different from what is found on ‘Sign in’ page

Expected Result:

Magic code input format/type should be consistent between ‘Sign in’ page, and ‘Contact methods’ page

Actual Result:

Magic code input format/type is not consistent between ‘Sign in’ page, and ‘Contact methods’ page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9.4
Reproducible in staging?: y
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-03.03.35.40.mp4

Recording.466.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683074798588979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01637d4b68a47f0a54
• Upwork Job ID: 1655998715589632000
• Last Price Increase: 2023-05-09

[MelvinBot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The magic code input format/type is inconsistent between the ‘Sign in’ page and the ‘Contact methods’ page.

What is the root cause of that problem?

The root cause of this problem is using TextInput inside ContactMethodDetailsPage but MagicCodeInput inside BaseValidateCodeForm

What changes do you think we should make in order to solve the problem?

To solve this problem, We just need to use MagicCodeInput inside ContactMethodDetailsPage as well

[aimane-chnaif]

Heads-up: we already planned on this so no reporting compensation is required here.

[melvin-bot]

@miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[miljakljajic]

Seems like we're good to update this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01637d4b68a47f0a54

[melvin-bot]

Current assignee @miljakljajic is eligible for the External assigner, not assigning anyone new.