[HOLD for payment 2023-06-01] [$1000] Dev: Entering the incorrect magic code spins the 'sign-in' button continuously offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open web chrome
2. Sign out
3. Enter email and click on continue
4. Turn your wifi off
5. Now enter any invalid code
6. Notice that the sign-in button spins continuously

Expected Result:

Entering the incorrect magic code should not spin the 'sign-in' button continuously

Actual Result:

Entering the incorrect magic code spins the 'sign-in' button continuously

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**Dev
Reproducible in staging?: occurs in Dev
Reproducible in production?: occurs in Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-02_17.46.35.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683030604469869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c807d0d63aa5777
• Upwork Job ID: 1653769834343481344
• Last Price Increase: 2023-05-10

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

This can be a bug or not, since when I reconnected to the internet, it will continue login.

Please re-state the problem that we are trying to solve in this issue.

Entering the incorrect magic code spins the 'sign-in' button continuously offline

What is the root cause of that problem?

In MagicCodeInput component, inside onChangeText function, we are checking if user completed the magic code, it would submit the magic code (which causes the button loading) whether it was offline or not. That's why even when were are offline and you completed the magic code input, it would trigger the submit and started loading.

App/src/components/MagicCodeInput.js

Lines 160 to 169 in 4d8dec2

	}, () => {
	const finalInput = this.composeToString(this.state.numbers);
	this.props.onChangeText(finalInput);
	// Blurs the input and removes focus from the last input and, if it should submit
	// on complete, it will call the onFulfill callback.
	if (this.props.shouldSubmitOnComplete && _.filter(this.state.numbers, n => ValidationUtils.isNumeric(n)).length === CONST.MAGIC_CODE_LENGTH) {
	this.inputRefs[this.state.editIndex].blur();
	this.setState({focusedIndex: undefined}, () => this.props.onFulfill(finalInput));
	}

What changes do you think we should make in order to solve the problem?

So we will need to update submit magic code condition inside the callback of the onChangeText 's setState that only submitted the request when user's online.

    isReadyToSubmit(numbers) {
        return this.props.shouldSubmitOnComplete && _.filter(numbers, n => ValidationUtils.isNumeric(n)).length === CONST.MAGIC_CODE_LENGTH;
    }

            // if it's offline, then we won't submit the magic code.
            if (!this.props.network.isOffline &&  this.isReadyToSubmit(this.state.numbers)) {
                this.inputRefs[this.state.editIndex].blur();
                this.setState({focusedIndex: undefined}, () => this.props.onFulfill(finalInput));
            }

In case we want to submit the request when user is back online, we can use componentDidUpdate to do that:

   componentDidUpdate(prevProps) {
        const isReconnecting = prevProps.network.isOffline && !this.props.network.isOffline;
      // if the app is reconnecting and the magic code is filled then submit the magic code.
        if (
            isReconnecting &&
            this.isReadyToSubmit(this.state.numbers)
        ) {
            const finalInput = this.composeToString(this.state.numbers);
            this.inputRefs[this.state.editIndex].blur();
            this.setState({focusedIndex: undefined}, () => this.props.onFulfill(finalInput));
        }

What alternative solutions did you explore? (Optional)

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~017c807d0d63aa5777

[MelvinBot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)