[HOLD for payment 2023-05-25] [$1000] Pressing enter twice on selecting currency from search closes the send money/request money option

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on send money
3. Select currency
4. Search for any currency, eg: USD
5. Press enter twice

Expected Result:

App should display enter amount page with selected currency as it does on single enter click

Actual Result:

App exits the send money/ request money option when we press enter twice to select the currency

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

twice.enter.exits.send.money.mp4

Recording.449.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682793162634169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d1daa29666491c62
• Upwork Job ID: 1655705158516649984
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[AmjedNazzal]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing enter twice on selecting currency from search closes the send money/request money option

What is the root cause of that problem?

The problem begins in how we handle the keyboard enter event

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 59 to 67 in 846a50c

	this.unsubscribeEnter = KeyboardShortcut.subscribe(
	enterConfig.shortcutKey,
	() => {
	const focusedOption = this.state.allOptions[this.state.focusedIndex];
	if (!focusedOption) {
	return;
	}
	this.selectRow(focusedOption);

The problem with this is that the Enter key will call selectRow for as many times as it's pressed quickly which will eventually lead to Navigation.goBack to be called twice which will exit the entire modal

Screen.Recording.2023-05-02.at.11.15.18.PM.mov

What changes do you think we should make in order to solve the problem?

We can set up a condition to wait for the excution of the selectRow function before calling it again thust resolving the issue while keeping the component flexible for handing multipleOptions and selection changing.

if(!isEnterDisabled){
    isEnterDisabled = true;
    let result = Promise.resolve(this.selectRow(focusedOption));
    InteractionManager.runAfterInteractions(() => {
        result.finally(() => isEnterDisabled = false);
    });
}

Result

Screen.Recording.2023-05-02.at.11.10.33.PM.mov

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[alexpensify]

I'm catching up from being OOO on Friday and Monday, I'll try to test this one soon.

[alexpensify]

I've run out of time this week; I will test over the weekend to continue the process.

[alexpensify]

No update

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d1daa29666491c62