Pressing CTRL+J again closes the popup (on other shortcuts, it keeps the option or popup open if shortcut keys pressed again)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Press CTRL + J and to observe that it opens keyboard shortcut popup
3. Press CTRL + J again and observe that it closed the popup

Expected Result:

App should keep the popup open as it does for all other shortcuts

Actual Result:

App closes the popup when we again press CTRL + J

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

CTRL.J.double.click.issue.mp4

Recording.427.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682792530683429

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aimane-chnaif]

This is not worth fixing. This was already mentioned while working on #14889 but decided to do nothing.

[huzaifa-99]

Didn't knew there was this case as @aimane-chnaif mentioned. Posting proposal here just because I spend time figuring it out.

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are trying to prevent the shortcut modal from closing by shortcut (CTRL+J) if its already opened

What is the root cause of that problem?

We are closing any modal when CTRL+J is pressed here.

What changes do you think we should make in order to solve the problem?

We need to check if the shortcut modal is already opened and if it is we will just return early from the CTRL+J shortcut.

I would suggest to use state, and since we are already reading the ONYXKEYS.IS_SHORTCUTS_MODAL_OPEN as prop, we should store this in KeyboardShortcutsModal.js state too with these changes

constructor(props) {
    super(props)
    this.state = {
        isModalOpen: this.props.isShortcutsModalOpen
    }
}

and update state with shortcut changes

componentDidMount() {
    const openShortcutModalConfig = CONST.KEYBOARD_SHORTCUTS.SHORTCUT_MODAL;
    this.unsubscribeShortcutModal = KeyboardShortcut.subscribe(openShortcutModalConfig.shortcutKey, () => {
        // make sure the modal is not already opened
        if (this.state.isModalOpen) return
        
        ModalActions.close();
        KeyboardShortcutsActions.showKeyboardShortcutModal();

        this.setState({ isModalOpen: true })
    }, openShortcutModalConfig.descriptionKey, openShortcutModalConfig.modifiers, true);

    const closeShortcutModalConfig = CONST.KEYBOARD_SHORTCUTS.ESCAPE;
    this.unsubscribeEscapeModal = KeyboardShortcut.subscribe(closeShortcutModalConfig.shortcutKey, () => {
        ModalActions.close();
        KeyboardShortcutsActions.hideKeyboardShortcutModal();

        this.setState({ isModalOpen: false })
    }, closeShortcutModalConfig.descriptionKey, closeShortcutModalConfig.modifiers, true, true);
}

and also use state in Modal

<Modal
    isVisible={this.state.isModalOpen}
    type={modalType}
    innerContainerStyle={{ ...styles.keyboardShortcutModalContainer, ...StyleUtils.getKeyboardShortcutsModalWidth(this.props.isSmallScreenWidth) }}
    onClose={() => {
        KeyboardShortcutsActions.hideKeyboardShortcutModal()
        this.setState({ isModalOpen: false })
    }}
>

What alternative solutions did you explore? (Optional)

N/A

[puneetlath]

I don't think this is really a bug. I think it's fine that it closes the modal. No one is going to think this is broken as a result of this behavior. I'm going to close, but feel free to reopen if you disagree!