[HOLD for payment 2023-05-16] [$1000] Close account - Unable to close a phone number account, error is displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App
2. Log in as a phone number account
3. Navigate to Settings > Security
4. Enter the phone number of the account in the input and click/tap on "close account"

Expected Result:

Verify you are logged out and that there's a message in the login screen that the account was "Closed Successfully" below the email field

Actual Result:

Error message "Please enter your default contact method to close your account." is appeared. Unable to close a phone number account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3412424

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6031788_sms2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fd514c6433bc4b98
• Upwork Job ID: 1651176090606776320
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to close an account with phone number as a default login method

What is the root cause of that problem?

For showing the phone number in the text we format the number with formatPhoneNumber which will take out the country code for national numbers. But while validating we are comparing 2 different strings(1 with applying format and 1 without it) which causes this issue.

App/src/pages/settings/Security/CloseAccountPage.js

Line 88 in f3fae40

const userEmailOrPhone = this.props.formatPhoneNumber(this.props.session.email);

What changes do you think we should make in order to solve the problem?

Apply the formatPhoneNumber on login id within validate method as well which makes sure both the strings are formatted for phone number default login method.

App/src/pages/settings/Security/CloseAccountPage.js

Line 78 in f3fae40

const userEmailOrPhone = Str.removeSMSDomain(this.props.session.email);

const userEmailOrPhone = this.props.formatPhoneNumber(this.props.session.email);

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01fd514c6433bc4b98

[MelvinBot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[MelvinBot]

Triggered auto assignment to @iwiznia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.