Login - Infinite spinner appears in login page after tap didn't receive a magic code

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app in the browser
2. Open another tab in the same browser
3. Log out from one of the tabs
4. Verify that in other tap the app is logged out.
5. Log in with the same user
6. Tap "Didn't receive the magic code"

Expected Result:

Infinite spinner does not appear in login page after tap didn't receive a magic code

Actual Result:

Infinite spinner appears in login page after tap didn't receive a magic code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2578.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186ac714505a4b6c5
• Upwork Job ID: 1650931778180227072
• Last Price Increase: 2023-04-25

[kbecciv]

Issue is not reproduced in Production, the flow is different

Recording.2579.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1682447137793479
Decision:

I would not block on this and also I think we are already on higher version of react native onyx so reverting would be a pain, I would make it a regression from that pr normal bug and let tienifr handle it, they usually fast

Also because this needs 2 tab to reproduce.

Probably from this PR #16531 cc @tienifr