Android - Setting - Android Staging app has noticeable lag as compared to PROD

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open New Expensify Staging App.
2. Tap on profile image.
3. Go to different menus (from workspace -> to profile, from profile -> preferences and so on).

Expected Result:

Staging app should be faster or should not have this behaviour.

Actual Result:

Noticeable lag experienced when using Android Staging app. It looks like the app shakes/rumbles/jumps a little bit in every change menu event (or when tapping between options).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.0.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Staging video

Bug6017051_Staging_android.mp4

Production video

Bug6017051_PROD_android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa13495b950dd931
• Upwork Job ID: 1657115257012432896
• Last Price Increase: 2023-05-12

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

@kbecciv out of curiosity, were you testing on a High Traffic account?

I can kinda see the app feels a little less smooth in my normal account, but curious if you noticed any difference based on the type of account.

[francoisl]

Could be a red herring, but I wonder if it has to do with disabling hardware acceleration in https://github.com/Expensify/App/pull/16532/files.

[kbecciv]

@francoisl Happening with gmail and expensifail accounts in same way.

[marcaaron]

Maybe my eye is not well trained, but I can't tell the difference here at all 👴

[francoisl]

Yeah so I've been running some tests on my physical device (Pixel 6) yesterday and I couldn't notice a real difference either.

• On main

screen-20230413-183937.mp4

• With hardware acceleration re-enabled (basically remove lines 13-14 of this PR)

screen-20230413-184404.mp4

I'm trying to run the same tests on a Pixel 3 AVD (since it has less power) but having trouble with Android Studio atm :/

[francoisl]

It's more noticeable on a Pixel 3 AVD, pretty sure it has to do with disabling hardware acceleration indeed.

• With hardware acceleration enabled

android_olderversion.mov

• On current main - animations feel less smooth

android_main.mov

cc @ArekChr do you know of a way we could re-enable hardware acceleration in #16532, but still get that fix to work? I'm thinking we'd somehow need to re-enable it at the application level, but disable it at the View level only (maybe?) for ImageView. I don't see a way to manage that directly from React Native in their docs, though.