[HOLD for payment 2023-05-04] [$1000] System redirects user to ‘Contact methods’ section when the user enters a wrong ‘Magic code’

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on ‘Profile’ avatar
2. Click on ‘Profile’ link
3. Click on ‘Contact method’ link
4. Click on ‘New contact method’ link
5. Enter email & password
6. Click on ‘Add’ button
7. Open the newly added email address
8. Enter a wrong magic code
9. Click on ‘Verify’ button

Expected Result:

User should remain on verification page, so that user can see the error immediately and corrects it

Actual Result:

User is redirected to ‘Contact methods’ section; hence, user can’t see immediate feedback on the error and corrects it

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-12.12.50.47.mp4

Recording.227.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1681248432274159
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a43c3d582df735a6
• Upwork Job ID: 1646555332468523008
• Last Price Increase: 2023-04-13

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a43c3d582df735a6

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App navigates to Contact Methods page even though the entered magic code is incorrect

What is the root cause of that problem?

While validating the magic code in the validateSecondaryLogin method, we are navigating the user to the contact methods page immediately after making an api call irrespective of the response.

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Line 153 in 0b5394e

User.validateSecondaryLogin(this.getContactMethod(), this.state.validateCode);

App/src/libs/actions/User.js

Lines 391 to 395 in 0b5394e

	API.write('ValidateSecondaryLogin', {
	partnerUserID: contactMethod,
	validateCode,
	}, {optimisticData, successData, failureData});
	Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS);

What changes do you think we should make in order to solve the problem?

In the ContactMethodDetailsPage component we can add some conditions within componentDidUpdate to make the decision of the navigation back to the methods page based on the prev and current props.
something like

• Check the errorFields.validateLogin is null
• Prev props pendingFields.validateLogin is pending

        const loginContactMethodData = this.props.loginList[this.getContactMethod()];

        if(!loginContactMethodData.errorFields.validateLogin 
            && prevProps.pendingFields && prevProps.pendingFields.validateLogin === CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE) {
                Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS);
        }

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.