[HOLD for payment 2023-05-22] [$1000] Last message does not updated in search

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. click on search button from userA
2. from userB, send a message to userA
3. in search check last message received by userA

Expected Result:

should show latest last message

Actual Result:

does not show latest last message

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-11.at.3.24.20.PM.mov

Recording.206.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681207300059949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5ec284c18cc0ab8
• Upwork Job ID: 1646229927855771648
• Last Price Increase: 2023-04-12

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[NicMendonca]

I can reproduce, but I am just not sure if this is something we update in real-time:

[NicMendonca]

asked here: https://expensify.slack.com/archives/C01SKUP7QR0/p1681321654759869

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f5ec284c18cc0ab8

[MelvinBot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the search modal is open, it does not update with the latest message.

What is the root cause of that problem?

we are only calling the function to update the options list when changing the search value:

App/src/pages/SearchPage.js

Lines 79 to 81 in c3d055d

	onChangeText(searchValue = '') {
	this.setState({searchValue}, this.debouncedUpdateOptions);
	}

This means that even though this.props.reports is updated through ONYX, the latest values will not be updated in the options list until updateOptions is called.

What changes do you think we should make in order to solve the problem?

Implement componentDidUpdate in SearchPage, and if prevProps.reports !== this.props.reports then call updateOptions.
Or, if we want slightly more efficiency we can specify the only data that will be displayed, in this case the last message text and the report name. We can use _.map to get these from reports and then compare them, only calling updateOptions if they have been changed.

What alternative solutions did you explore? (Optional)

None

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that when the search page is open and a new message is received, sent using another device, the last message does not update in the search page last message preview.

What is the root cause of that problem?

In the SearchPage, all the data about the reports and their relevant lastMessage is stored in the state. When the report's last message is updated, the state is not updated. Thus, this causes the issue where the stale data is displayed in the Search Page.

App/src/pages/SearchPage.js

Lines 60 to 76 in e8bc6a8

	const {
	recentReports,
	personalDetails,
	userToInvite,
	} = OptionsListUtils.getSearchOptions(
	props.reports,
	props.personalDetails,
	'',
	props.betas,
	);
	this.state = {
	searchValue: '',
	recentReports,
	personalDetails,
	userToInvite,
	};

What changes do you think we should make in order to solve the problem?

We need to add a componentDidUpdate and check that if prevProps.report equal this.props.report, do nothing. Else, we will update the state again using the above mentioned code and latest props.

This will ensure that the state is up to date with the latest changes.

What alternative solutions did you explore? (Optional)

While testing for this issue, I noticed the bug where if the search page is open and the name / profile picture of a user changes, it is not updated in the search page.

Please let me know if this should be handled in this issue or if I should create a bug report for this.