[HOLD for payment 2023-06-08] [$1000] Italic [Attachment] message is considered as attachment and app crashes on click of download for that message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open the app on another device and login with user B
3. From user A, send following message: _[Attachment]_
4. From user B, long press the message and observe that 'Download' is available in option in place of 'copy to clipboard'
5. Press on download

Expected Result:

App should not consider normal message as attachment

Actual Result:

App considers normal message as attachment

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

attachment.in.italic.is.considered.as.attachment.mp4

Recording.205.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681205583378899

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ef972b4b00c3551
• Upwork Job ID: 1646266195415273472
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

I'm not able to reproduce this. I only have the "copy to clipboard" or "mark as unread" option when long holding on the message.

Will add Eng for more eyes.

[MelvinBot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

Oop yep @lschurr did you make the [Attachment] italic (i.e. _[Attachment]_)? That made it work for me. It's in the title but it's not in the reproduction instructions

EDIT: And by "made it work" I mean the bug did indeed show up.

[lschurr]

Ah, I'll change the repro steps. Do you think this should be external or internal @dangrous?

[dangrous]

I think External should be fine!

[MelvinBot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[MelvinBot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.