[HOLD for payment 2023-05-16] [$1000] A red dot mark should appear on the workspace list to identify which workspace is getting an error

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on chrome web
2. Select any workspace
3. Change the name of the workspace and type in multiple emojis until you get an error
4. Click on save
5. Now go back to the workspaces on the settings page. Notice that red dot mark is present. Click on the workspaces . Now notice that red dot is not being displayed on the workspace that's getting the error. With this, it becomes difficult to search for the workspace that's getting an error. You need to manually go through each of the workspaces to identify the error location.

Expected Result:

Red dot should be displayed on the right hand side of the workspace's name to identify the workspace which has an error

Actual Result:

Red dot is not appearing on the workspace that's getting an error and thus it becomes difficult to find the error location and need to manually check each workspace one by one.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

reddot-2023-03-31_20.42.10.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680274808391779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a76d3cbdeb5d1409
• Upwork Job ID: 1648491112127827968
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

I think it's necessary to take a look at this thread to discuss and agree upon the final expected behavior: https://expensify.slack.com/archives/C01GTK53T8Q/p1667841851085549?thread_ts=1666955764.560879&cid=C01GTK53T8Q

This is the PR implementing that thread's conclusion: #12491. Basically, we won't show red dot:

if the error is in the workspace itself and not in policy member or custom unit

[arielgreen]

@tienifr I agree. Thanks for linking that!

I think the conclusion of that thread makes it pretty clear this isn't a bug, it's behaving as expected. I'm bolding the relevant line:

• If the error is on creation, the error is shown inside the workspace in the main page
• If the error is on deletion, the error is shown in the workspace list
• If the error is on any of the fields:
  • If you still have access to the policy, the error is shown next to the field you edited
  • If you don't have access to the policy, the error is shown in the workspace list

Going to raise in Slack and see if we want to change this.

[MelvinBot]

@arielgreen Whoops! This issue is 2 days overdue. Let's get this updated quick!

[arielgreen]

Looks like from the linked thread this is, in fact, a bug. Let's get it fixed.