Skip to content

[HOLD for payment 2023-05-02] [$1000] Inconsistent capitalization in product #17239

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to web chrome
  2. Go to any chat
  3. Send message and hover over the 'Copy to clipboard' and 'Mark as unread'.
  4. Notice that only the first letter is in the capital form
  5. But now hover over the call icon and notice that the first letter of the Call is in the capital. (Even in web messenger, it's 'Start a video call', where 'c' is small)

  1. Go to the Settings > Payments
  2. Select a payment method to delete

  1. Open Chat
  2. Upload a attachment

  1. Open the app
  2. Open settings
  3. Open workspaces
  4. Open any workspace
  5. Open connect bank account
  6. Click on connect manually
  7. Without filling any details, click on continue and observe that Routing number and Account number fields as 'N' small in labels but capital in error
  8. Fill in details in step 1 and click on continue. eg details: routing no= 210021002, acc no= 1234
  9. On step 2, check below company address field, instruction text has 'b' small for boxes.
  10. Without filling any field, click on Save & continue
  11. Observe that for company address field, validation message has 'b' capital for box
  12. Observe that for fields like phone number, zip code, there is no capital word in validation
  13. Observe that 'Tax ID number' field has small 'n' in label and capital 'N' in validation error
  14. Observe that 'Company type' field has small 't' in label and capital 'T' in validation error
  15. Observe that for 'Incorporation state' field, even though field is dropdown, validation error says 'Please enter' in place of 'Please select'

Expected Result:

  • To maintain consistency between the other tooltips, the 'C' should be small in the tooltip for the call icon

  • The header in the Delete Account modal "A" should be in small letters, as the header in the "Delete workspace" modal "w" is in small letters and same in "Delete comment" modal

  • Uploading Attachment... message "A" should be in small letters

  • App should maintain consistent capitilization and validation statements for fields in connect bank account

Actual Result:

  • The 'C' is in the capital letter in the call icon tooltip

  • The header "Delete Account" in the Delete Account modal "A" is capitalized

  • Uploading Attachment... message "A" is capitalized

  • App has many inconsistencies in capitilization and validation statements for fields in connect bank account

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-04-10_20.41.01.mp4

Untitled

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: expensify.slack.com/archives/C049HHMV9SM/p1680972128646799

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ecbf592ef39ed301
  • Upwork Job ID: 1645820257278033920
  • Last Price Increase: 2023-04-11

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions