[HOLD for payment 2023-05-23] [$1000] Chat- Files mp4 with long name extend to the far edges of the screen.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login
3. Navigate to a conversation
4. Tap the grey plus button in compose box
5. Tap on add attachment
6. Mobile - Tap on choose from gallery
7. Select a mp4 file with long name

Expected Result:

Attachment preview doesn't extend to the far edges of the screen.

Actual Result:

Files mp4 with long name extend to the far edges of the screen.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.95.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6007064_Screen_Recording_20230405_183417_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fea9233c3c7ebaef
• Upwork Job ID: 1653854126087110656
• Last Price Increase: 2023-05-12

[MelvinBot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@greg-schroeder 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

@greg-schroeder 10 days overdue. Is anyone even seeing these? Hello?

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Chat- Files mp4 with long name extend to the far edges of the screen.

What is the root cause of that problem?

AttachmentView is render via this at line 280, Parent View has styles.imageModalImageCenterContainer applied at 271

App/src/components/AttachmentModal.js

Lines 271 to 287 in 83b20de

	<View style={styles.imageModalImageCenterContainer}>
	{this.props.reportID ? (
	<AttachmentCarousel
	reportID={this.props.reportID}
	onNavigate={this.onNavigate}
	source={this.props.source}
	onToggleKeyboard={this.updateConfirmButtonVisibility}
	/>
	) : this.state.source && this.state.shouldLoadAttachment && (
	<AttachmentView
	source={source}
	isAuthTokenRequired={this.props.isAuthTokenRequired}
	file={this.state.file}
	onToggleKeyboard={this.updateConfirmButtonVisibility}
	/>
	)}
	</View>

imageModalImageCenterContainer uses width: '100%', so content within it will expand fully.

App/src/styles/styles.js

Lines 1916 to 1921 in 83b20de

	imageModalImageCenterContainer: {
	alignItems: 'center',
	flex: 1,
	justifyContent: 'center',
	width: '100%',
	},

Attachment view render via this code for mp4 or other attachment. So content within it will expand fully this is the root cause of the problem.

App/src/components/AttachmentView.js

Lines 90 to 93 in 83b20de

	return (
	<View
	style={styles.defaultAttachmentView}
	>

What changes do you think we should make in order to solve the problem?

From AttachmentModal.js we have to pass containerStyles props to <AttachmentView> as shown below:

  <AttachmentView
      containerStyles={[styles.mh5]}     //  *** Add this
      source={source}
      isAuthTokenRequired={this.props.isAuthTokenRequired}
      file={this.state.file}
      onToggleKeyboard={this.updateConfirmButtonVisibility}
  />

We have to use containerStyles props in AttachmentView view as shown code below:

return ( 
  <View 
   style={[styles.defaultAttachmentView, ...props.containerStyles]}
  > 
     ....
  </View>
);

Important: AttachmentView is used multiple places like chat listing and attachment modal. This is the reason why we added containerStyles prop.

So while we render it within attachment modal we can set horizontal margin and during chat list it will behave normally.

This will solve the problem and shows horizontal margin when needed as shown in result video.

What alternative solutions did you explore? (Optional)

None

Results

Attachment.mov

[MelvinBot]

@greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@greg-schroeder 12 days overdue. Walking. Toward. The. Light...

[MelvinBot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?