[HOLD for payment 2023-04-27] [$1000] No red line for error in login page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to https://staging.new.expensify.com/
2. If logged in then log out of the app
3. Enter any number without country code to trigger error
4. Press on continue

Expected Result:

App should underline 'Phone or email' field with red color like it does on error on other fields throughout the app

Actual Result:

App keeps the green underline on 'Phone or email' field on error instead of underlining the field with red.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680512267199719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01097b0f4dbbc159f0
• Upwork Job ID: 1643196523312259072
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

I'm getting a red line when I reproduce, so closing

[laurenreidexpensify]

[dhanashree-sawant]

Hi @laurenreidexpensify, numbers over or under 10 digits provide proper error with red underline but try geniune phone number without country code like: 8286673854

[laurenreidexpensify]

Ah good catch, confirmed on staging error is reproducible

[suphero]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue we are trying to solve is the incorrect error underlining the color on the login page when a user enters a wrong phone number without a country code. Currently, the app keeps the green underline on the 'Phone or email' field on error instead of underlining the field with red.

What is the root cause of that problem?

The root cause of the problem is that the code for the login page is not correctly handling errors returned from the server endpoint /api?command=BeginSignIn. Specifically, the code is not detecting the error message returned from the server and is not triggering the proper error state in the login form.

App/src/pages/signin/LoginForm.js

Lines 167 to 187 in 4efde84

	const formErrorText = this.state.formError ? this.props.translate(this.state.formError) : '';
	const serverErrorText = ErrorUtils.getLatestErrorMessage(this.props.account);
	return (
	<>
	<View accessibilityLabel={this.props.translate('loginForm.loginForm')} style={[styles.mt3]}>
	<TextInput
	ref={el => this.input = el}
	label={this.props.translate('loginForm.phoneOrEmail')}
	value={this.state.login}
	autoCompleteType="username"
	textContentType="username"
	nativeID="username"
	name="username"
	onChangeText={this.onTextInput}
	onSubmitEditing={this.validateAndSubmitForm}
	autoCapitalize="none"
	autoCorrect={false}
	keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS}
	errorText={formErrorText}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

To fix the problem, we should determine the error condition by adding the hasError property to the TextInput component to trigger the error state of the component. This will cause the TextInput component to underline the field with red.

const formErrorText = this.state.formError ? this.props.translate(this.state.formError) : '';
const serverErrorText = ErrorUtils.getLatestErrorMessage(this.props.account);
const hasError = !_.isEmpty(formErrorText) || !_.isEmpty(serverErrorText);
...
<TextInput
    ...
    errorText={formErrorText}
    hasError={hasError}
/>

What alternative solutions did you explore? (Optional)

None