Inconsistence website validation between client and server

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Workspace => Connect Bank Account => Connect Bank Account Manually.
2. At step 2, try to fill all the valid information, with website field, try to type a valid website with an upper case first letter. (For example: https://facebook.com/), Press Save & Continue.
3. Notice that there's an error "Please provide a valid Website".

Expected Result:

User should allow to enter website with upper case "h" in http.

Actual Result:

There's an error "Please provide a valid Website" when user tries to input website with upper case "h" in http.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-03-30.at.22.53.33.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680191727392799

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

👋 @MonilBhavsar looks like you worked on this a little while back through this PR. Presumably this is going to be an internal issue? Can you confirm?

[MonilBhavsar]

User should allow to enter website with upper case "h" in http.

I don't think this is the issue and we want to fix. On server side we only allow lower cased protocols and this issue proposes to allow upper cased letter and make it more permissive. It is also against our security guidelines.

IMO :donothing:

[trjExpensify]

Great, thanks for confirming! Closing.

[situchan]

Should we also fix this issue?
Can’t parse the url if the letter ‘h’ of https is uppercase

[MonilBhavsar]

Sorry, I think I missed it,
@situchan yes, we can fix that issue since we're not validating that URL. Also, I see slack and Whatsapp handles this case, so yes we can fix that 👍