[HOLD for payment 2023-04-10] [$1000] Hovering over again to ‘Copy to clipboard’ seems to split the ‘Copy to clipboard’ into two lines in the second click for long emails

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chrome web > Click on + button > New Chat > Type a Long email and hit enter
2. Click on the avatar > Hover over the copy to clipboard icon and see that the text ‘Copy to Clipboard’ displays in one line on the tooltip
3. Next click on the icon and it displays ‘copied’. Again, hover over the icon and see that the ‘Copy to Clipboard’ splits into two lines on the tooltip. It doesn't happens with shorter emails, but only with longer emails.

Expected Result:

Hovering over again to ‘Copy to clipboard’ should not split the ‘Copy to clipboard’ into two lines in the second click for long emails. There should be consistency and it should display in the single line only.

Actual Result:

Hovering over again to ‘Copy to clipboard’ splits the ‘Copy to clipboard’ into two lines in the second click for long emails

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1699.mp4

email.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678781967498269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113ef7945a36f778f
• Upwork Job ID: 1638556398300405760
• Last Price Increase: 2023-03-29

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@michaelhaxhiu Still overdue 6 days?! Let's take care of this!

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hovering over again to ‘Copy to clipboard’ seems to split the ‘Copy to clipboard’ into two lines in the second click for long emails

What is the root cause of that problem?

When the text in the tooltip is updated, we will re-calculate the tooltipContentWidth

Firstly, we set tooltipContentWidth to undefined

App/src/components/Tooltip/TooltipRenderedOnPageBody.js

Lines 88 to 96 in ebc03db

	componentDidUpdate(prevProps) {
	if (prevProps.text === this.props.text && prevProps.renderTooltipContent === this.props.renderTooltipContent) {
	return;
	}
	// Reset the tooltip text width to 0 so that we can measure it again.
	// eslint-disable-next-line react/no-did-update-set-state
	this.setState({tooltipContentWidth: undefined}, this.updateTooltipContentWidth);
	}

And then the width of the tooltip will be undefined by this logic

App/src/styles/getTooltipStyles.js

Lines 103 to 105 in ebc03db

	const wrapperWidth = tooltipContentWidth && (tooltipContentWidth < maxWidth
	? tooltipContentWidth + (spacing.ph2.paddingHorizontal * 2) + 1
	: maxWidth);

If the tooltip's width is undefined and new text(Copy to clipboard: 86px) is added that exceeds the width of the tooltip, then the text will wrap onto a new line. This means that the text will be split into two or more lines in order to fit within the dimensions of the tooltip.
After that, when the tooltip content width is updated

App/src/components/Tooltip/TooltipRenderedOnPageBody.js

Lines 98 to 106 in ebc03db

	updateTooltipContentWidth() {
	if (!this.contentRef) {
	return;
	}
	this.setState({
	tooltipContentWidth: this.contentRef.offsetWidth,
	});
	}

The offsetWidth attribute that is being used to obtain the width of the tooltip element in the code only provides the width of a single line, and does not account for the entire content text width which in this case is Copy to clipboard: 86px. As a result, the tooltip's width does not get updated to match the full width of its content text.

What changes do you think we should make in order to solve the problem?

when the tooltipContentWidth is undefined, we should update the width of the tooltip is maxWidth
in

App/src/styles/getTooltipStyles.js

Lines 103 to 105 in ebc03db

	const wrapperWidth = tooltipContentWidth && (tooltipContentWidth < maxWidth
	? tooltipContentWidth + (spacing.ph2.paddingHorizontal * 2) + 1
	: maxWidth);

We should remove brackets that are added by this PR
This is expected code:

const wrapperWidth = tooltipContentWidth && tooltipContentWidth < maxWidth
        ? tooltipContentWidth + (spacing.ph2.paddingHorizontal * 2) + 1
        : maxWidth;

So that, because the width of the tooltip is larger than the content text, the text will not be split into multiple lines and the offsetWidth attribute should correctly return the width of the entire content text (in this case, Copy to clipboard: 86px)

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-03-22.at.15.37.05.mov

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0113ef7945a36f778f

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.