[HOLD for payment 2023-03-09] Keyboard is visible for a brief moment on request/send money page after getting back from currency search page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app in android
2. Open any report
3. Click on plus
4. Click on Request money/ send money/ split bill
5. Click on currency
6. On currency search page, when keyboard is displayed for search, click on 'X' to close and get back to previous page

Expected Result:

Keyboard should close first and then app should get back to previous request/send money screen

Actual Result:

App navigates to request/send money screen first and then closes the keyboard (works properly on mWeb android chrome)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native

Version Number: 1.2.70-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

keyboard.issue.android.app.mp4

az_recorder_20230212_205641.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676043921470679

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[narefyev91]

Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.

[narefyev91]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App doesn't automatically hide keyboard on android - while moving between screens.

What is the root cause of that problem?

The main issue - when user goes back - no events fires to app to dismiss keyboard (if keyboard has been already opened)

What changes do you think we should make in order to solve the problem?

The main change should be:

1. using new event handler to detect when user wants to live current screen.
2. when event triggers - needs to close keyboard (if keyboard has been already opened)
   Example:

        this.beforeRemoveSubscription = this.props.navigation.addListener('beforeRemove', () => {
            if (this.props.isKeyboardShown) {
                Keyboard.dismiss();
            }
        });

What alternative solutions did you explore?

We can solve issue in 2 ways - globally and locally.
For global one - we can add subscription to event beforeremove inside ScreenWrapper class and add in compose withKeyboardState HOC - which will guaranty that keyboard will be closed on any screen which was wrapped in ScreenWrapper
For local one - doing the same steps - but only under IOUCurrencySelection class

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[mountiny]

We are trying to avoid making changes related to react-navigation now as we are reworking this. I think we could try this solution locally @narefyev91 and confirm it works well there on all the native platforms.

Can you please create a PR and fill in the template with testing done on all the platforms? Thank you very much!