[HOLD for payment 2023-02-08] pinned chat become unpinned when user pinned chat in offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to offline
2. click into an existing chat or create a new one
3. click on pin button to pin the chat
4. confirm the pin icon is lit up, i.e. the chat was pinned
5. go to online

Expected Result:

chat should be pinned

Actual Result:

chat becomes unpinned

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Seems to be only affecting Chrome on computer and mobile device

Version Number: 1.2.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1378.mp4

Screen.Recording.2023-01-20.at.3.01.23.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674207539542629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018bae5da04b47a887
• Upwork Job ID: 1618712481741504512
• Last Price Increase: 2023-01-26

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018bae5da04b47a887

[marcaaron]

Can reproduce this one on dev. You don't need to create a new chat with a user while offline though. It happens because we are making an identical request and for some reason we are trying to deduplicate them here:

App/src/libs/actions/NetworkRequestQueue.js

Line 20 in 9193948

persistedRequests = lodashUnionWith(persistedRequests, retryableRequests, _.isEqual);

This is not how the sequential queue is supposed to work so there's a gap in the implementation. Gonna grab this one.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)