[HOLD for payment 2023-03-13] [$4000] LHN - Workspace badge is not fully visible/missing for some Room chats

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log i with expensifail account (applausetester+0901abb@applause.expensifail.com/Feya8Katya)
3. Plus on Fub menu
4. Select New Room
5. Put 00--00--00--00--00--00--00--00--00 on room name
6. Select WS ( PR testing)
7. Save Room
8. Go back to LHN

Expected Result:

WS badge is fully visible and present for all chats

Actual Result:

Workspace badge is not fully visible/missing for some Room chats

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.58.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ac522930fd1c9d2
• Upwork Job ID: 1620286474913542144
• Last Price Increase: 2023-02-14

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[JmillsExpensify]

Wow this one is pretty wild. I need another day to circle back and close the loop on this one.

[JmillsExpensify]

Alright, sorry for the delay! I'm able to reproduce this one.

[JmillsExpensify]

That said, @shawnborton it'd be good to get your take on this one. Like on the one hand, I'm not sure if we should optimize for showing the workspace badge in this case, because the the room name is ultimately more important. Overall, I'm not convinced this is a bug. I'm going to hold off triaging it until we get another set of eyes.

[shawnborton]

I think this is such an edge case.

That being said, one easy way to fix this would be to give the badge a min-width so that in the very least, you can always see at least 3-4 characters of the badge as well.

I think ideally the room name and badge would be truncated via ellipsis, I could have sworn that's how it was implemented.

@bernhardoj do you have any thoughts on this? Since you worked on this PR here.

[shawnborton]

@bernhardoj can't comment on this issue, but sent me this on Slack:

Hi, I see you mentioned me on this issue, but I can't comment on it, so I chat you here 😅.

I also initially thought that we already truncate for both chat name and the pill's text. However, after looking at the code again, apparently we didn't do that.

The chat name has flex shrink 0 set to it which means the text will never be shrunk and will take the whole width. We do that to address this issue #11799 (comment)

Even before the text pill feature added, the flex shrink 0 already being used, but only on compact (focus) mode. Now, we apply the flex shrink 0 to the chat name no matter what the mode is because now the text pill always sits next to the chat name.

So I say we open this up as a bug and allow @bernhardoj to submit a proposal to fix since he originally worked on this. I don't think this is a regression because it's working as expected from the original PR, but this was an oversight in our testing.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016ac522930fd1c9d2