Significant performance improvements get flagged as deploy blockers

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Merge a PR that causes a statistically significant improvement in our of our performance metrics.

Expected Result:

The PR should not be marked as a deploy blocker, the new baseline average should adjust.

Actual Result:

The PR is marked as a deploy blocker.

Workaround:

Remove the blocker (not possible for non-Expensify employees).

Platforms:

GH Actions

View all open jobs on GitHub

[roryabraham]

cc @AndrewGable @hannojg: #13714 (comment)

[roryabraham]

@flaviadefaria no need to make any upwork job for this, it should be addressed by @hannojg when he's back from vacation.

I also think we can make this a weekly. After all, it's not every day when we make statistically significant performance improvements to the app.

[luacmartins]

I think Andrew addressed this already - #14074

[AndrewGable]

Yes, this is done. Let me know if you see it fail again and I am happy to look into it.