[HOLD for payment 2023-01-16] [$1000] Android - Connect Manually -The App can crash after clicking on the back button during manual Bank account flow

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the WS settings
2. Connect bank account --> Connect manually , enter Routing/Account numbers and open Company information dialog
3. Click few times on the back button until workspace menu is open again
4. Repeat 2-3 until crash is reproduced

Expected Result:

The user should be able to use back button during manual bank account flow without any issues

Actual Result:

The App can crash after clicking on the back button during manual Bank account flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native

Version Number: 1.2.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5878592_mobizen_20221228_081305-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5662eb8534df401
• Upwork Job ID: 1610404762022748160
• Last Price Increase: 2023-01-03

[puneetlath]

I was able to reproduce this. I got this error on the emulator.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c5662eb8534df401

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[allroundexperts]

Proposal

The error occurs because the component un mounts before the timeout is executed here.
https://github.com/Expensify/App/blob/main/src/components/TextInput/BaseTextInput.js#L69

Fix

We can do either of the following:

1. Check if this.input is not null in the setTimeout callback.
2. Save the reference of the timeout and in the componentDidUnmount function, remove that reference so that the callback does not execute.