[HOLD for payment 2022-12-20] [$1000] Profile : Upload/Delete Photo popup not hiding

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Actions Performed:

1. Go to Settings -> Profile
2. Click Profile Photo
3. Select Upload Photo

Expected Result:

Should hide options after selecting one of them

Actual Result:

Not hiding even after selecting one of the options. Need to click outside the options to make it go away

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.37-0
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-12-07.at.10.30.59.PM.mov

Recording.3212.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel / Applause internal team
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670432916695299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a23347fca2f83eaf
• Upwork Job ID: 1600971997335502848

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[francoisl]

I can reproduce. @isabelastisser can you please apply the Engineering label to get it assigned. Doesn't work if I do it since I'm already on the engineering team.

I'll start investigating in the meantime.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

Ok I just ran a git bisect, and it seems to come from this PR, which makes sense because it changed PopoverMenu quite a bit. cc @aimane-chnaif if you have any idea of the specific issue here.

[francoisl]

Ok so I managed to fix it by adding a this.setState({isMenuVisible: false}); here in each menu item's onSelected, but the fact that it broke here for this componenet makes me think it might also be broken in other places we use PopoverMenu, so I don't know if it's the best possible fix.

[marcaaron]

@Luke9389 want to assist with this one?

I don't have much context on the linked PR so would probably just revert it so it can go back to reviews.

@francoisl feels like the popover should be closing. I tested in a few other places and it closes. For some reason it doesn't close here. So, the workaround you mentioned might work, but doesn't explain the root cause.