Fix SplitBill flow

[luacmartins]

Problem

Coming from this comment and this thread, there are a few inconsistencies with the Split Bill flow that we need to address:

• Users should be able to deselect members when the split is initiated from an existing group Correct the logic for when bill split particpants can be selected #13279

• Splits initiated from an existing group should always post the Split message to the respective group. Additionally, it should not create a separate group if users deselected participants. There's a limit of 9 participants in the selection.

Example:

1. As memberA: create a groupDM with memberB, memberC & memberD
2. Go to the “+” menu inside the groupDM > click “Split bill”
3. Enter $100 > click Next
4. Deselect memberD > click Split $100
5. The split message from memberA is added to the groupDM: Split $100 with memberB and memberC
6. In the memberA:memberB DM the request action from memberA is added: Requested $33.33 from memberB
7. In the memberA:memberC DM the request action from memberA is added: Requested $33.33 from memberC
8. In the memberA:memberD DM there is nothing added, as memberD was excluded from the split.

• Similarly, a bill split initiated from within a policy room should add a split message to the room and create off-policy IOUs in each individual DM. There's no participant limit here.

• When splitting a bill with a single participant, the split message should still be posted to the chat.

Example:

1. As memberA, create a groupDM with memberB and memberC
2. Go to the + menu inside the groupDM > click Split bill
3. Enter $100 > click Next
4. Deselect memberC > click Split $100
5. The split message from memberA is added to the groupDM: Split $100 with memberB
6. In the memberA:memberB DM the request action from memberA is added: Requested $50.00 from memberB
7. In the memberA:memberC DM there is nothing added, as memberC was excluded from the split.

Why is this important?

It's the expected behavior for Split Bill flows

Solution

Fix the flow!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181093ec5c397a56b
• Upwork Job ID: 1608288606003535872
• Last Price Increase: 2022-12-29

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

PR in review!

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@luacmartins Still overdue 6 days?! Let's take care of this!

[mananjadhav]

@luacmartins Can you please assign someone to help with the payment of the issue?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0181093ec5c397a56b