[HOLD for regression tests] New Room-An error message "Invalid reportName" appears when entering a long name for New Room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Put on FAB button -> New Room
4. Enter the long name for New Room
5. Choose the workspace from the dropdown menu
6. Click "Create room"

Expected Result:

The new room is created

Actual Result:

An error message "Invalid reportName" appears when entering a long name for New Room

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.36.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5847200_Recording__3180.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01519fd144a2d452d5
• Upwork Job ID: 1606449256443441152
• Last Price Increase: 2022-12-24

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

I think you uploaded the wrong video

[Puneet-here]

Proposal

We get an error when using 80 character long name. It's not possible to add more than 80 characters at room name.
We can lower this and we should show an error because there isn't any error right now

App/src/CONST.js

Line 321 in 2e8d907

MAX_ROOM_NAME_LENGTH: 80,

We need to add a validation here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 91 in 2e8d907

validate() {

        if (ValidationUtils.doesFailCharacterLimit(CONST.REPORT.MAX_ROOM_NAME_LENGTH, this.state.roomName)) {
            errors.roomName = this.props.translate('newRoomPage.exceededCharLimit');
        }

There's no limit for room name at room settings so I think we should also add the same validation there

App/src/pages/ReportSettingsPage.js

Line 97 in 2e8d907

validate() {

And if we wanna use a char limit on input we can use maxLength prop

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[miljakljajic]

Hey Andrew! What do you think of Puneet's proposal above?

[dhairyasenjaliya]

is it reproducible? I'm getting an invalid room while saving with max character

[miljakljajic]

It's reproducible for me in Chrome: